-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VmCloud Resize/Reconfigure form bugs #1163
Fix VmCloud Resize/Reconfigure form bugs #1163
Conversation
@miq-bot add_lable blocker,bug,fine/yes |
@miq-bot add_label blocker,bug,fine/yes |
@tzumainn unrecognized command 'add_lable', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
Checked commits mansam/manageiq-ui-classic@394aeb8~...00d4ba9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
I think that only solution to https://bugzilla.redhat.com/show_bug.cgi?id=1445018 should be applied to So I suggest backporting only 394aeb8 and 00d4ba9 to What do you thing? @mansam @tzumainn @mzazrivec @simaishi |
@petrblaho makes sense to me - my fault for forgetting you were testing on master |
@mansam Can you create a Fine backport for this that only includes the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1445018 ? |
I was about to backport this, perfect timing 😄 Will wait for a Fine PR. |
Backported to Fine via #1186 |
This fixes a bug where the buttons on the Resize form don't work if you access the form from outside of an explorer view.
https://bugzilla.redhat.com/show_bug.cgi?id=1445011
This also fixes a bug where retrieving data to populate the form throws an exception because the VM to be resized does not have a flavor.
https://bugzilla.redhat.com/show_bug.cgi?id=1445018