Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed decodeURI call. #1167

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Removed decodeURI call. #1167

merged 1 commit into from
Apr 27, 2017

Conversation

h-kataria
Copy link
Contributor

decodeURI was causing an issue rendering html on screen when '%' character is present in html output. Removed decodeURI call as html is getting rendered correctly.

https://bugzilla.redhat.com/show_bug.cgi?id=1444853

@bzwei can you please test.

decodeURI was causing an issue rendering html on screen when '%' character is present in html output. Removed decodeURI call as html is getting rendered correctly.

https://bugzilla.redhat.com/show_bug.cgi?id=1444853
@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2017

Checked commit h-kataria@9e0cffa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@dclarizio dclarizio requested a review from himdel April 26, 2017 17:41
@dclarizio
Copy link

@himdel just need a quick glance :)

@bzwei
Copy link
Contributor

bzwei commented Apr 26, 2017

Seems a simple fix. Tested good 👍

@himdel
Copy link
Contributor

himdel commented Apr 27, 2017

Looks good, URI decoding is done by the browser, so no need to do it twice 👍.

(That said, I'm not 100% sure the js_function('#{html.gsub(..).gsub(..)}') approach is safe in all the cases, but that's a separate issue (but if you do look into it, it may make sense to merge with the miq-sanitize directive).)

@himdel himdel added this to the Sprint 60 Ending May 8, 2017 milestone Apr 27, 2017
@himdel himdel merged commit 48b51dd into ManageIQ:master Apr 27, 2017
simaishi pushed a commit that referenced this pull request Apr 27, 2017
@simaishi
Copy link
Contributor

simaishi commented Apr 27, 2017

Fine backport details:

$ git log -1
commit 08f4b0af78c3889ced8acddbdad7eb40a1503a02
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Apr 27 09:23:00 2017 +0000

    Merge pull request #1167 from h-kataria/std_output_fix
    
    Removed decodeURI call.
    (cherry picked from commit 48b51dd9a41e6d79143e9d90edf299ab881c8394)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1446245

@h-kataria h-kataria deleted the std_output_fix branch April 27, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants