Ansible refresh button: correctly send miq_grid_checks #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit mzazrivec@58cf4c9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@mzazrivec Is there a BZ for this? The PR can be backported to |
|
@simaishi I added the blocker bz into the initial description of this PR. |
simaishi
pushed a commit
that referenced
this pull request
Apr 27, 2017
…s_for_ansible_refresh Ansible refresh button: correctly send miq_grid_checks (cherry picked from commit 5ed75bf) https://bugzilla.redhat.com/show_bug.cgi?id=1446303
|
Fine backport details: |
mzazrivec
deleted the
correctly_send_miq_grid_checks_for_ansible_refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the ansible refresh button would not send
miq_grid_checksparameterwhen launched from ansible repositories list view. Without this change, the button would be
effectively useless in ansible repo list view.
Discovered by @durandom in https://github.com/ManageIQ/manageiq-ui-classic/pull/1083/files#r113627921
https://bugzilla.redhat.com/show_bug.cgi?id=1446267