Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miq_tabs_init - use observe queue for tab switching too #1179

Merged
merged 1 commit into from
May 31, 2017
Merged

miq_tabs_init - use observe queue for tab switching too #1179

merged 1 commit into from
May 31, 2017

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 27, 2017

Since many tab switches are in forms, especially non-angular form, we have a timing bug where a tab switch request can happen before all the changes to inputs are processed.

Changing so that tabs use the observe queue as well.

Cc @jkrocil, @lkhomenk

Since many tab switches are in forms, especially non-angular form, we have a timing bug where a tab switch request can happen before all the changes to inputs are processed.

Changing so that tabs use the observe queue as well.
@himdel himdel added the bug label Apr 27, 2017
@mfalesni
Copy link
Contributor

@himdel Is the miqJqueryRequest something we can detect by invoking some javascript? We have a hook that is called before the tab is clicked, so I was thinking we could call something and wait for it to be gone before going on the tab.

@himdel
Copy link
Contributor Author

himdel commented Apr 27, 2017

@mfalesni $.active, you're already doing that. The problem is you have to wait for the other requests before switching tabs, and some inputs only do the request on blur - after clicking somewhere else, like, a tab :).

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/f0aa5772c380216af8748f30067ced31c0c7d9ae with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@mfalesni
Copy link
Contributor

@himdel Hmm, then it should be possible to do something like:

getCurrentlyFocusedElement().blur();

That would then let the requests kick off and we could grab it with our standard in-flight check, right?

@mzazrivec mzazrivec added this to the Sprint 62 Ending Jun 5, 2017 milestone May 31, 2017
@mzazrivec mzazrivec merged commit 9c08e51 into ManageIQ:master May 31, 2017
@himdel himdel deleted the tab-observe branch June 5, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants