Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decorators for certain TreeNode icons/images #118

Merged
merged 3 commits into from
Jan 10, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Jan 10, 2017

Decorate the given objects as for listicon images/icons.
https://www.pivotaltracker.com/n/projects/1613907/stories/129371557

@epwinchell
Copy link
Contributor

@miq-bot assign @himdel

@himdel himdel self-assigned this Jan 10, 2017
@skateman skateman changed the title [WIP] Use decorators for certain TreeNode icons/images Use decorators for certain TreeNode icons/images Jan 10, 2017
@miq-bot miq-bot removed the wip label Jan 10, 2017
@himdel
Copy link
Contributor

himdel commented Jan 10, 2017

It's a weird combination of querying the decorator for the only thing it's not really useful for, and not using it for anything else.

But on the other hand, that will probably fix itself once we only use the decorators for that so.. 👍

waiting for green..

@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2017

Checked commits skateman/manageiq-ui-classic@2ab446b~...814d3be with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
6 files checked, 0 offenses detected
Everything looks good. 👍

@himdel himdel added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 10, 2017
@himdel himdel added the euwe/no label Jan 10, 2017
@himdel himdel merged commit f62afc9 into ManageIQ:master Jan 10, 2017
@skateman skateman deleted the treenode-decorators branch January 10, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants