Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate DOM id in textual summaries. #1184

Merged
merged 2 commits into from
May 2, 2017
Merged

Fix duplicate DOM id in textual summaries. #1184

merged 2 commits into from
May 2, 2017

Conversation

martinpovolny
Copy link
Member

The fieldset is a typo and #main_div is already above #tab_all_tabs_div.

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commits martinpovolny/manageiq-ui-classic@accb059~...dd6d17f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

PanSpagetka
PanSpagetka approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@PanSpagetka PanSpagetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no duplicate DOM ids in Database left 👍

@martinpovolny
Copy link
Member Author

ping @himdel

@himdel himdel added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
@himdel himdel merged commit 4df50be into ManageIQ:master May 2, 2017
@martinpovolny martinpovolny deleted the dupl_dom_id_db branch November 28, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanSpagetka PanSpagetka PanSpagetka approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @PanSpagetka @himdel @mzazrivec