Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VMWare vApp type to the Create Orchestration Template type list #1201

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Add VMWare vApp type to the Create Orchestration Template type list #1201

merged 1 commit into from
Apr 28, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Apr 28, 2017

Add VMWare vApp type to the Create Orchestration Template type list

https://bugzilla.redhat.com/show_bug.cgi?id=1446399

@lgalis
Copy link
Contributor Author

lgalis commented Apr 28, 2017

@miq-bot add_label bug, fine/yes, blocker

@lgalis
Copy link
Contributor Author

lgalis commented Apr 28, 2017

@bzwei, @dclarizio - please review

@miq-bot miq-bot added the wip label Apr 28, 2017
@dclarizio dclarizio self-assigned this Apr 28, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 28, 2017

Checked commit lgalis@b6dd115 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@lgalis lgalis changed the title [WIP] Add VMWare vApp type to the Create Orchestration Template type list Add VMWare vApp type to the Create Orchestration Template type list Apr 28, 2017
@miq-bot miq-bot removed the wip label Apr 28, 2017
@bzwei
Copy link
Contributor

bzwei commented Apr 28, 2017

Tested and works. 👍

@dclarizio dclarizio merged commit 5f982cf into ManageIQ:master Apr 28, 2017
@dclarizio dclarizio added this to the Sprint 60 Ending May 8, 2017 milestone Apr 28, 2017
simaishi pushed a commit that referenced this pull request Apr 28, 2017
@simaishi
Merge pull request #1201 from lgalis/add_vapp_orchestration_type_to_list
c54b613 
Add VMWare vApp type to the Create Orchestration Template type list
(cherry picked from commit 5f982cf)

https://bugzilla.redhat.com/show_bug.cgi?id=1446784
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c54b6138257baf29e510ced418151350dc8bfc47
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Apr 28 13:52:10 2017 -0700

    Merge pull request #1201 from lgalis/add_vapp_orchestration_type_to_list
    
    Add VMWare vApp type to the Create Orchestration Template type list
    (cherry picked from commit 5f982cf92532fdabae0af55f614cd4130f5a4424)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1446784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
blocker bug fine/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgalis @miq-bot @bzwei @simaishi @dclarizio