Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uid to report fields VM Chargeback Report #1208

Merged
merged 1 commit into from
May 1, 2017
Merged

Add uid to report fields VM Chargeback Report #1208

merged 1 commit into from
May 1, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented May 1, 2017

-vm_uid needs to be added to CHARGEBACK_ALLOWED_FIELD_SUFFIXES to make it available in Available Fields when creating a new VM chargeback report.

screen shot 2017-05-01 at 10 44 00 am

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1433411

@miq-bot add_label bug, cloud intel/reporting

@miq-bot
Copy link
Member

miq-bot commented May 1, 2017

Checked commit jntullo@7f22860 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@dclarizio dclarizio self-assigned this May 1, 2017
@dclarizio dclarizio merged commit 70cb5df into ManageIQ:master May 1, 2017
@dclarizio dclarizio added this to the Sprint 60 Ending May 8, 2017 milestone May 1, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 8b69977e9be0837eb9e787ba5218d4275f694228
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon May 1 08:44:52 2017 -0700

    Merge pull request #1208 from jntullo/bz/return_vm_uid
    
    Add uid to report fields VM Chargeback Report
    (cherry picked from commit 70cb5dfe3a9d2d87112470a16262e3a1e98ea99b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1449398

simaishi pushed a commit that referenced this pull request Jun 5, 2017
@simaishi
Merge pull request #1208 from jntullo/bz/return_vm_uid
fa38a15 
Add uid to report fields VM Chargeback Report
(cherry picked from commit 70cb5df)

https://bugzilla.redhat.com/show_bug.cgi?id=1458921
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

Fine backport details:

$ git log -1
commit fa38a151884423f84dc4e850f07d8dc9176b3378
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon May 1 08:44:52 2017 -0700

    Merge pull request #1208 from jntullo/bz/return_vm_uid
    
    Add uid to report fields VM Chargeback Report
    (cherry picked from commit 70cb5dfe3a9d2d87112470a16262e3a1e98ea99b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug euwe/backported fine/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jntullo @miq-bot @simaishi @dclarizio