Add special handling for image? column in ApplicationController
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
changed the title
image? column in ApplicationController
|
Checked commit mansam@06d0403 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
👍 verified this in conjunction with the PR on which this depends |
|
@mzazrivec Hi! The PR upon which this depends was merged - can this one be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows views using the
image?predicate to display the column properly.Relies on ManageIQ/manageiq#12970, which this change was split from.