Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-initialize 'Remove Resources' drop down after copy button is pressed. #1246

Merged
merged 1 commit into from
May 3, 2017
Merged

Re-initialize 'Remove Resources' drop down after copy button is pressed. #1246

merged 1 commit into from
May 3, 2017

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented May 3, 2017 •
edited
Loading

@h-kataria h-kataria requested a review from lgalis May 3, 2017 15:47
@miq-bot
Copy link
Member

miq-bot commented May 3, 2017

Checked commit h-kataria@cc89cca with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

lgalis
lgalis approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@lgalis lgalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Verified in the UI as well.

@dclarizio dclarizio merged commit aa90ede into ManageIQ:master May 3, 2017
@dclarizio dclarizio added this to the Sprint 60 Ending May 8, 2017 milestone May 3, 2017
@lgalis
Copy link
Contributor

lgalis commented May 10, 2017

This PR is also needed for https://bugzilla.redhat.com/show_bug.cgi?id=1449624 - marking as blocker

@lgalis
Copy link
Contributor

lgalis commented May 10, 2017

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request May 10, 2017
@simaishi
Merge pull request #1246 from h-kataria/set_remove_resources_after_copy
009e263 
Re-initialize 'Remove Resources' drop down after copy button is pressed.
(cherry picked from commit aa90ede)

https://bugzilla.redhat.com/show_bug.cgi?id=1449811
https://bugzilla.redhat.com/show_bug.cgi?id=1449810
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 009e2637842d1f949cf2a1818b79e104347bbf52
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed May 3 13:18:08 2017 -0700

    Merge pull request #1246 from h-kataria/set_remove_resources_after_copy
    
    Re-initialize 'Remove Resources' drop down after copy button is pressed.
    (cherry picked from commit aa90ede610f6e5ce51358559859806eb9c6df59f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1449811
    https://bugzilla.redhat.com/show_bug.cgi?id=1449810

@h-kataria h-kataria deleted the set_remove_resources_after_copy branch June 27, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgalis lgalis lgalis approved these changes

Assignees

@dclarizio dclarizio

Labels
blocker bug fine/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-kataria @miq-bot @lgalis @simaishi @dclarizio