Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology - indicate no results when searching #1277

Merged
merged 5 commits into from
May 9, 2017
Merged

Topology - indicate no results when searching #1277

merged 5 commits into from
May 9, 2017

Commits on May 9, 2017

  1. Topology - shared/topology/not_found - a partial to show when search … 

    …matches 0 items

included in all the topologies and styled so that it overlays the content

https://bugzilla.redhat.com/show_bug.cgi?id=1445857
    @himdel
    himdel committed May 9, 2017
    Configuration menu
    Copy the full SHA
    5a99481 View commit details
    Browse the repository at this point in the history

  2. topologyService.mixinSearch - mixin the search methods from common co… 

    …de instead of having N identical copies

this just moves searchNode and resetSearch to the service, under a `mixinSearch` method that adds these to the current scope when called
    @himdel
    himdel committed May 9, 2017
    Configuration menu
    Copy the full SHA
    f0eaf66 View commit details
    Browse the repository at this point in the history

  3. TopologyService - set searching & notFound on scope when appropriate 

    so that we can show the not_found message when searching and notFound :)

https://bugzilla.redhat.com/show_bug.cgi?id=1445857
    @himdel
    himdel committed May 9, 2017
    Configuration menu
    Copy the full SHA
    3ca042b View commit details
    Browse the repository at this point in the history

  4. TopologyService (js) - use ===

    @himdel
    himdel committed May 9, 2017
    Configuration menu
    Copy the full SHA
    7785975 View commit details
    Browse the repository at this point in the history

  5. TopologyService - use size() not lenght for d3 size comparison 

    because apparently length is always 0 or 1
    @himdel
    himdel committed May 9, 2017
    Configuration menu
    Copy the full SHA
    203fddc View commit details
    Browse the repository at this point in the history