Add feature buttons for physical server toolbar #1299
Conversation
|
@gabrielsvinha Please include the button screenshot in your first PR comment. |
|
@AparnaKarve Done it. |
| @@ -0,0 +1,9 @@ | |||
| class ApplicationHelper::Button::PhysicalServerFeatureButton < ApplicationHelper::Button::GenericFeatureButton | |||
There was a problem hiding this comment.
why do we need this class?
and if we need it why do we override the visible? behavior (as that is really what the GenericFeatureButton is about).
There was a problem hiding this comment.
The idea is to improve this class in the future, disabling certain types of features and buttons in some cases. (still to be defined by Lenovo)
gabrielsvinha
force-pushed
the
ph_server_buttons
branch
2 times, most recently
from
44d976c
to
70c0b98
Compare
|
Checked commit gabrielsvinha@70c0b98 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
- add physical server option for toolbar chooser
|
@martinpovolny All the code around |
|
I appreciate the effort to make PRs small to make the review simple. Thx! But please, don't go too far. In most cases the PR should somehow wrap a piece of work. Also there's no need to include an empty method in most cases. Anyway merging this. |
|
@martinpovolny Got it! |
|
@gabrielsvinha @AparnaKarve This PR depends on #1298, which was closed in favor of #1380 and 1380 is Should this PR and 1380 go to Fine? If it should, do you have a BZ? |
|
@simaishi None of the Can you remove the 2 labels from this PR? |
This pull request implements buttons features and view settings for physical server toolbar:
app/helpers/application_helper/physical_server_center.rb
app/helpers/application_helper/physical_servers_center.rb
And the feature buttons:
app/helpers/application_helper/button/physical_server_feature_button.rb
app/helpers/application_helper/button/physical_server_feature_button_with_disable.rb
Implemented for PhysicalServer#show and PhysicalServer#show_list
Depends on the actions implemented in #1298