Add flash message partial to ems_container/_show_dashboard #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit ZitaNemeckova@54b0dcd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@ZitaNemeckova @h-kataria please make sure that all of the dashboards we currently have get the flash message support. |
|
@ZitaNemeckova same change should be applied to infrastructure provider dashboard view as well.i think currently we only have dashboard views for Container & Infrastructure Providers only. |
|
@dclarizio @h-kataria I forgot to mention that Infra Provider already has it thanks to #983 |
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
Add flash message partial to ems_container/_show_dashboard (cherry picked from commit 6ec9adc) https://bugzilla.redhat.com/show_bug.cgi?id=1459903
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1436341
Flash message for Infra Provider was added via #983
Compute -> Containers -> Providers -> any provider -> set view to Dashboard -> Configuration -> Edit this Provider -> Make small change or click Cancel
Before:
After:
@miq-bot add_label bug, fine/yes