Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying tag from DialogFieldTagControl #1316

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented May 9, 2017

We are able to keep only one value of selected
tag in DialogFieldTagControl, fix me if I am wrong

Test Scenario

  • Create Service Dialog With Tag Element
    screen shot 2017-05-09 at 15 29 34
  • use it in service
  • order the service and choose any tag
    screen shot 2017-05-09 at 15 29 34
  • review the request:

Before:
screen shot 2017-05-09 at 15 57 13

After:
screen shot 2017-05-09 at 15 33 25

@miq-bot assign @himdel (not sure who is right person for the review)
@miq-bot add_label bug

@miq-bot
Copy link
Member

miq-bot commented May 9, 2017

@lpichler 'himdel (not sure who is right person for the review)' is an invalid assignee, ignoring...

@miq-bot miq-bot added the bug label May 9, 2017
We are able to keep only one value of selected
tag in DialogFieldTagControl.
@lpichler lpichler force-pushed the display_tag_name_in_tag_control_dialog branch from 27ca826 to 3aa70f1 Compare May 9, 2017 15:47
@miq-bot
Copy link
Member

miq-bot commented May 9, 2017

Checked commit lpichler@3aa70f1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change itself is fine, but since we're modifying the logic anyway, I think there's a lot of value in pulling it out into a helper function that we can then write a spec for.

@martinpovolny martinpovolny merged commit 9d0d1d0 into ManageIQ:master May 16, 2017
@martinpovolny martinpovolny added this to the Sprint 61 Ending May 22, 2017 milestone May 16, 2017
@lpichler lpichler deleted the display_tag_name_in_tag_control_dialog branch May 16, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants