Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent relationship for physical server textual summary #1322

Merged
merged 2 commits into from
May 11, 2017

Conversation

gabrielsvinha
Copy link
Contributor

This Pull Request adds the parent provider relationship for the PhysicalServer#show page summary. Showing the Ems relative to its parent.

captura de tela de 2017-05-09 19-10-29

In the example above, the EmsPhysicalInfra name is Lenovo and is shown below the host label.

Copy link
Contributor

@AparnaKarve AparnaKarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the #show spec which should address the spec failure:

ems = FactoryGirl.create(:ems_physical_infra)
physical_server = FactoryGirl.create(:physical_server, :computer_system => computer_system, :ems_id => ems.id)

- Add parent relationship for physical server with ems_physical_infra
@miq-bot
Copy link
Member

miq-bot commented May 11, 2017

Checked commits gabrielsvinha/manageiq-ui-classic@59e9e86~...7e29169 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@AparnaKarve
Copy link
Contributor

LGTM

@dclarizio OK to merge.

@dclarizio dclarizio merged commit 3db553e into ManageIQ:master May 11, 2017
@dclarizio dclarizio added this to the Sprint 61 Ending May 22, 2017 milestone May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants