-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing stylesheet extension #1332
Conversation
446a0ad
to
7c50807
Compare
Checked commit hayesr@7c50807 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@hayesr can you add before/after screenshots. |
@h-kataria I included the current state of PDFs, but this change alone will make no visual difference. Without ManageIQ/manageiq#14793 the path that is sent to Prince is broken and you get the unstyled version. (and without this PR the core PR will result in errors shown in the PDF) |
@hayesr thx for the screenshot and info. i will merge this PR and once core PR is merged PDF should look nice and beautiful :-) |
Fix missing stylesheet extension (cherry picked from commit 6d21b2e) https://bugzilla.redhat.com/show_bug.cgi?id=1460815
Fine backport details:
|
Euwe backport (to manageiq repo) details:
|
Travis is failing for Euwe branch now... @hayesr @h-kataria would you mind taking a look?
|
Fixed spec test failure caused by EUWE backport of ManageIQ/manageiq-ui-classic#1332
Referencing the file without an extension may have worked in older versions of Prince/Rails/etc. Now it seems necessary.
Core PR ManageIQ/manageiq#14793 depends on this change.
Related to this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1447940
And part of the fixes in #1090
Current look of PDFs
/cc @dclarizio