Remove "Confirm Password" input field previously required for Validation

[AparnaKarve]

This PR removes the Confirm Password input field from all angular forms.

Going forward, the user no longer has to key-in his/her password twice.

Before:

After:

https://bugzilla.redhat.com/show_bug.cgi?id=1427488

[AparnaKarve]

@miq-bot add_label bug,fine/no,'angular_dialogs',

[miq-bot]

@AparnaKarve Cannot apply the following label because they are not recognized: 'angular_dialogs'

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[himdel]

@AparnaKarve what's here looks good I think, but it also looks like there's a half missing, and it has to be in this PR.

All the backend code is still working with these fields - I see a lot of code like

@edit[:new][:log_password] = @edit[:new][:log_verify] = @ps.authentication_password(:default).to_s

@edit[:new][:log_verify]           = depot.authentication_password

@edit[:amqp_verify_status] = (edit_new[:amqp_password] == edit_new[:amqp_verify])

if !host.authentication_userid(:ipmi).blank? && params[:ipmi_password] != params[:ipmi_verify]

etc. etc.

[AparnaKarve]

All the backend code is still working with these fields - I see a lot of code like

@himdel Agreed. I will work on that.

[AparnaKarve]

I have deleted all _verify references from the backend code as well.

In ems_common, I started deleting all _verify code and noticed that in many areas where the _verify code was called there was also a lot of obsolete code (@edit related). So it was a good clean-up opportunity there.

[AparnaKarve]

@himdel Can we get some traction on this PR?
Once these changes are in, I would like to look into converting the Credentials controller to a component and while at it address some of the code climate errors like Similar code found in 1 other location.
Thanks.

[himdel]

@AparnaKarve sorry for taking so long, it's a big one :)..

But.. so far, can you re-check those backend bits please?

I'm still seeing these...

app/controllers/application_controller.rb
610:    if (@edit[:new][:log_password] == @edit[:new][:log_verify]) && @edit[:new][:uri_prefix] != "nfs" &&
611:       (!@edit[:new][:uri].blank? && !@edit[:new][:log_userid].blank? && !@edit[:new][:log_password].blank? && !@edit[:new][:log_verify].blank?)

app/controllers/pxe_controller/pxe_servers.rb
297:      elsif @edit[:new][:log_password] != @edit[:new][:log_verify]
412:    @edit[:new][:log_verify] = params[:log_verify] if params[:log_verify]
446:    @edit[:new][:log_verify]      = @ps.has_authentication_type?(:default) ? @ps.authentication_password(:default).to_s : ""
487:      @edit[:new][:log_password] = @edit[:new][:log_verify] = @ps.authentication_password(:default).to_s

(Also seeing this, but not sure if that's the same case:

app/controllers/ops_controller/settings/common.rb
662:       :customer_org, :customer_org_display, :customer_userid, :customer_password, :customer_verify].each do |key|

)

[AparnaKarve]

@himdel No worries. Agree, it's a big one.

app/controllers/pxe_controller/pxe_servers.rb

==> PXE Server is not an angular form and hence did not touch that code.

---

app/controllers/application_controller.rb
610:    if (@edit[:new][:log_password] == @edit[:new][:log_verify]) && @edit[:new][:uri_prefix] != "nfs" &&
611:       (!@edit[:new][:uri].blank? && !@edit[:new][:log_userid].blank? && !@edit[:new][:log_password].blank? && !@edit[:new][:log_verify].blank?)

==> Related to PXE Server as well

---

app/controllers/ops_controller/settings/common.rb
662:       :customer_org, :customer_org_display, :customer_userid, :customer_password, :customer_verify].each do |key|

==> Looks related to settings_rhn_edit.
Again, not angular code and hence have left it as is.

[himdel]

Maybe this one?

app/assets/javascripts/controllers/ems_common/ems_common_form_controller.js
275:      ($scope.emsCommonModel.default_verify != '' && $scope.angularForm.default_verify.$valid);

[himdel]

app/assets/stylesheets/angular.css
4:input.ng-invalid-verifypasswd, select.ng-invalid-verifypasswd,

I guess that style can be removed if the directive is..

[AparnaKarve]

Yes, we can get rid of that style.

[AparnaKarve]

Are you on my branch?

Please check this:
https://github.com/AparnaKarve/manageiq-ui-classic/blob/dd61075251eb3b565a1f3effd2c1089bb265f297/app/assets/javascripts/controllers/ems_common/ems_common_form_controller.js

And you will not see any default_verify stuff.

[himdel]

@AparnaKarve You have to rebase ;) (sorry, should have mentioned that - introduced by #1304)

[AparnaKarve]

Ah, I see...yesterday's PR that got merged added the _verify :)

[AparnaKarve]

@himdel Should I wait for a couple more minutes in case you have anything more?

I want to push a final commit that addresses these last few stray _verify's

[himdel]

Other than that, LGTM 👍 (+ all those deletions 😺)

I still want to give this some clicking in the UI, it surprises me how many ems_common methods are dead, but I think this should be ready (except for #1335 (comment) and #1335 (comment)) :).

[miq-bot]

Checked commits AparnaKarve/manageiq-ui-classic@42d8562~...0282686 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
18 files checked, 0 offenses detected
Everything looks fine. 🍪

[himdel]

OK, looks like EmsCommon is always used together with Mixins::EmsCommonAngular or with MiddlewareCommonMixin, so I guess that explains the dead code :) Tried to touch a few provider dialogs and a middleware one in the UI, looks like nothing crashes 👍 .. waiting for green travis..

[AparnaKarve]

@himdel Travis has been green 💚 for the last 4 days :)
Can you please merge if you are around?

/cc @dclarizio

[himdel]

Sorry @AparnaKarve, I am now.. merged :)