Fix Default tab error indicator for OpenStack Infra

[AparnaKarve]

No error indicator is displayed on the Default tab when OpenStack Infra is selected in the New Infra Provider form
Also New Cloud Provider form shows 3 tabs right off the bat even though Type is not selected

Before (New Infra Provider Form with OpenStack selected and no error indicator on Default tab) --

After (New Infra Provider Form with OpenStack selected and error indicator visible on Default tab) --

---

Before (New Cloud Provider Form with no Type selected and 3 tabs visible) --

After (New Cloud Provider Form with no Type selected and no tabs visible) --

https://bugzilla.redhat.com/show_bug.cgi?id=1451130

[AparnaKarve]

@miq-bot add-label bug,fine/yes

[mzazrivec]

On the infra provider page:

• select openstack infra, the error indicator is there
• select vmware
• select openstack infra again, the error indicator is not there

[miq-bot]

Checked commits AparnaKarve/manageiq-ui-classic@73efadc~...8ec313c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

[AparnaKarve]

@mzazrivec Thanks!
I myself was not convinced about the changes in 9188efa since that was just helping alleviate the issue but was not exactly the root cause.
The root cause, believe it or not, was the the equality statement in 8ec313c == Vs. ===

FYI, The below comparison between null and undefined came into play for this particular use case.

null == undefined //true

null === undefined //false

[simaishi]

Fine backport details:

$ git log -1
commit 7257c9f1e200cfeb17074c1a011c63bd8f1e9d07
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue May 16 13:56:51 2017 +0200

    Merge pull request #1341 from AparnaKarve/fix_new_ems_form_error_indicator
    
    Fix Default tab error indicator for OpenStack Infra
    (cherry picked from commit 55e60069140bcf01b34c9d09903c4f3bd53cc194)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459923