Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dialog name validation added. #1361

Merged
merged 1 commit into from
May 17, 2017

Conversation

h-kataria
Copy link
Contributor

Show flash message and disable Add/Save button when user enters a dialog name in 'Create New' field that already exists in the db

https://bugzilla.redhat.com/show_bug.cgi?id=1449345

List of available Dialogs:
existing_dialogs_list

After fix:
after1

after2

@gmcculloug @syncrou please test.
cc @dclarizio

Show flash message and disable Add/Save button when user enters a dialog name in 'Create New' field that already exists in the db

https://bugzilla.redhat.com/show_bug.cgi?id=1449345
@miq-bot
Copy link
Member

miq-bot commented May 16, 2017

Checked commit h-kataria@6828c70 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug
Copy link
Member

@h-kataria @dclarizio Tested changes and worked as expected. 👍

@dclarizio dclarizio merged commit 7ee8f63 into ManageIQ:master May 17, 2017
@dclarizio dclarizio added this to the Sprint 61 Ending May 22, 2017 milestone May 17, 2017
simaishi pushed a commit that referenced this pull request Jun 8, 2017
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit bd9fc43dc6b1b384c773df353629cc1564a7ce7a
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed May 17 08:49:51 2017 -0700

    Merge pull request #1361 from h-kataria/validate_new_dialog_name
    
    New dialog name validation added.
    (cherry picked from commit 7ee8f6301e4f197b42fd30a73c5eebf99bbe1bdc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459990

@h-kataria h-kataria deleted the validate_new_dialog_name branch June 27, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants