Fix oVirt metrics DB name validation #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the 'Database name' field of the 'C & U Database' tab of the authentication for is always mandatory. In addition the presence check is done using the 'required' attribute. The result of that is that the provider can't be edited unless that field is filled, even if the metrics aren't enabled, and the fact that the validation failed isn't explicitly shown in the 'C & U Database' tab header. To fix these issues this patch changes the form to use 'ng-required' instead of 'required', and to make the field mandatory only when the host name is not empty. https://bugzilla.redhat.com/1451301
|
Checked commit https://github.com/jhernand/manageiq-ui-classic/commit/944f4960d09549afbed0bea45d2238adf97a64aa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good to me. |
|
@martinpovolny can you please review? |
|
@miq-bot add_label fine/yes |
|
looks good |
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
…dation Fix oVirt metrics DB name validation (cherry picked from commit 76f80da) https://bugzilla.redhat.com/show_bug.cgi?id=1460002
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the 'Database name' field of the 'C & U Database' tab of the
authentication form is always mandatory. In addition the presence check
is done using the 'required' attribute. The result of that is that the
provider can't be edited unless that field is filled, even if the
metrics aren't enabled, and the fact that the validation failed isn't
explicitly shown in the 'C & U Database' tab header. To fix these issues
this patch changes the form to use 'ng-required' instead of 'required',
and to make the field mandatory only when the host name is not empty.
https://bugzilla.redhat.com/1451301