Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Tag class to fix display of tags on Infra Topology. #1404

Merged
merged 1 commit into from
May 24, 2017

Conversation

h-kataria
Copy link
Contributor

Fixed a Label on the screen

https://bugzilla.redhat.com/show_bug.cgi?id=1454295

before
before

after
after

@miq-bot
Copy link
Member

miq-bot commented May 22, 2017

Checked commit h-kataria@fd5fa53 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this May 24, 2017
@mzazrivec mzazrivec added this to the Sprint 62 Ending Jun 5, 2017 milestone May 24, 2017
@mzazrivec mzazrivec merged commit 6482ca3 into ManageIQ:master May 24, 2017
simaishi pushed a commit that referenced this pull request Jun 8, 2017
Added missing Tag class to fix display of tags on Infra Topology.
(cherry picked from commit 6482ca3)

https://bugzilla.redhat.com/show_bug.cgi?id=1460036
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit 15149d076b6de975c0b9372d3bea87708f737d3f
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed May 24 10:57:06 2017 +0200

    Merge pull request #1404 from h-kataria/show_tags_on_infra_topology
    
    Added missing Tag class to fix display of tags on Infra Topology.
    (cherry picked from commit 6482ca38afdb022c3e565dfb070cde3595e64e97)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460036

@simaishi
Copy link
Contributor

simaishi commented Jun 9, 2017

@h-kataria please address Travis failure (https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/240982977) in Fine branch:

  1) InfraTopologyService#build_kinds creates the expected number of entity types
     Failure/Error:
       expect(infra_topology_service.build_kinds.keys).to match_array(
         [:InfraManager, :EmsCluster, :Host, :Vm])
     
       expected collection contained:  [:EmsCluster, :Host, :InfraManager, :Vm]
       actual collection contained:    [:EmsCluster, :Host, :InfraManager, :Tag, :Vm]
       the extra elements were:        [:Tag]

h-kataria added a commit to h-kataria/manageiq-ui-classic that referenced this pull request Jun 9, 2017
Fixed broken spec test on Fine caused by backport of ManageIQ#1404
@h-kataria h-kataria deleted the show_tags_on_infra_topology branch June 27, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants