Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed condition in disabled? method #1428

Merged
merged 1 commit into from
May 25, 2017

Conversation

h-kataria
Copy link
Contributor

Fixed a check in disabled? method introduced in commit 4b33666 during refactoring of toolbar methods in ManageIQ/manageiq#13052

https://bugzilla.redhat.com/show_bug.cgi?id=1455283

Fixed a check in disabled? method introduced in commit 4b33666 during refactoring of toolbar methods in ManageIQ/manageiq#13052

https://bugzilla.redhat.com/show_bug.cgi?id=1455283
@miq-bot
Copy link
Member

miq-bot commented May 24, 2017

Checked commit h-kataria@2bd10ee with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny merged commit 89fa2d4 into ManageIQ:master May 25, 2017
@martinpovolny martinpovolny added this to the Sprint 62 Ending Jun 5, 2017 milestone May 25, 2017
simaishi pushed a commit that referenced this pull request Jun 9, 2017
@simaishi
Copy link
Contributor

simaishi commented Jun 9, 2017

Fine backport details:

$ git log -1
commit e3c9c3bde9b7699354f5ac208ab2a8143539af00
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu May 25 10:50:06 2017 +0200

    Merge pull request #1428 from h-kataria/suspend_role_button_fix
    
    Fixed condition in disabled? method
    (cherry picked from commit 89fa2d4217859863362fbc8bfc9aa2d938980adb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460366

@h-kataria h-kataria deleted the suspend_role_button_fix branch June 27, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants