Enable to download AWS volumes snapshot summary #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1439629 Enable to download AWS volumes snapshot summary in PDF format when reaching Storage > Block Storage > Volume Snapshots page and clicking on one of the snapshots to get into summary page.
|
@miq-bot add_label bug |
|
Checked commit hstastna@54ea9d4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@hstastna Do we maintain any test-cases for this kind of feature? That should avoid future bugs. I guess we also have similar issue in generating PDF report for network_port |
|
@psachin I am not sure if we maintain any test-cases for this kind of feature. And could you please specify the issue for network_port? Because if I reach Networks -> Network Ports and choose one of them, downloading PDF summary works fine. |
|
@hstastna Ah! I don't see any problem downloading PDF summary for network port. My bad. Thanks for the fix. |
simaishi
pushed a commit
that referenced
this pull request
Jun 9, 2017
Enable to download AWS volumes snapshot summary (cherry picked from commit 817d2dd) https://bugzilla.redhat.com/show_bug.cgi?id=1460385
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1439629
Enable to download AWS volumes snapshot summary in PDF format
when reaching Storage > Block Storage > Volume Snapshots page
and clicking on one of the snapshots to get into summary page.