Use matching via descendants for CloudNetwork model

[lpichler]

we need to filter CloudNetworks also according to their Network Manager when this limitation is set up in user's group in tab Host & Cluster.

but for allowing this feature, backend PR is needed.

Links

• https://bugzilla.redhat.com/show_bug.cgi?id=1445163
• Allow matching via descendants for CloudNetworks (via network manager) manageiq#15271

cc @mzazrivec
@miq-bot assing @martinpovolny

@miq-bot add_label bug

[miq-bot]

@lpichler unrecognized command 'assing', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

[lpichler]

@himdel

[himdel]

@lpichler I'm not sure this does anything? (Or maybe I'm reading the instructions wrong.) What I did:

Created a group (abc), checked only one Network provider in the Assign Filters H&C tree:

Created a user with that group, logged in as that user.

On master, I'd expect to see all the networks, regardless of provider - check, that's true.
With this PR, I'd expect to see only the networks under Azure (the provider I checked).

I'm seeing all regardless:

[himdel]

@lpichler Does this depend on ManageIQ/manageiq#15367 now?

EDIT: no.. but Libor is investigating..

[martinpovolny]

I know that you have not introduced that code, but the pattern for exceptions in process_params_options is just ugly.

We need to do something about it. I wonder how we would work with that if the report data was served through the API.

Thoughts?

[lpichler]

@martinpovolny yes I was saying the same thing to myself and it is on my to do list.

First, I was thinking that process_params_options is returning params for rbac. But there is are keys (like [:view], [:model]) which are not related to rbac, I don't know whether they are needed at all. So it needs the deeper look.

WIP: because of @hidmel's findings

[miq-bot]

Checked commit lpichler@36bd3a3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[lpichler]

@himdel thanks for testing!
I had here https://github.com/ManageIQ/manageiq-ui-classic/pull/1474/files#diff-023cabd4eee712930c5f9ff1a7bbd765R22 class which was including OpenStack namespace before.

and you had to use filter Azure Network Manager (instead of Azure )

[himdel]

@lpichler LGTM now, thanks 👍

When I have only the wrong Azure, I don't see any Cloud Networks now. And when I enable Azure Network, I see only those now.

[himdel]

👍

[lpichler]

@mzazrivec @martinpovolny can you merge it, please? thanks!

[simaishi]

@lpichler not sure where this change goes in Fine branch... Can you create a Fine PR?

[lpichler]

@simaishi yes fine PR #1584

[simaishi]

Backported to Euwe via ManageIQ/manageiq#15444

[simaishi]

Backported to Fine via #1584