Change ng-show to ng-if in button group #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hiding buttons they will never be created at all. Prevents problems when enter is clicked and calls first button's on-click action.
|
Checked commit ZitaNemeckova@00b3b54 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Jun 12, 2017
Change ng-show to ng-if in button group (cherry picked from commit 8323d58) https://bugzilla.redhat.com/show_bug.cgi?id=1460791
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hiding buttons they will never be created at all. Prevents problems when enter is clicked and calls first button's on-click action.
https://bugzilla.redhat.com/show_bug.cgi?id=1454294
Automation -> Ansible -> Repositories -> Edit any Repository -> Instead of pressing Save press Enter on keyboard
(or any Angular form)
Before:
After:
@miq-bot add_label bug