Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Verbosity drop down on both Provisioning & Retirement tabs #1493

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Added Verbosity drop down on both Provisioning & Retirement tabs #1493

merged 1 commit into from
Jun 8, 2017

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Jun 6, 2017 •
edited
Loading

  • Added new 'Verbosity' drop down on Playbook catalog item form and summary screen to display saved Verbosity field values.
  • Added/Updated spec tests to verify changes

https://www.pivotaltracker.com/n/projects/1613907/stories/146545759
verbosity_drop_down

catalog_item_form_verbosity

catalog_item_summary_existing_item

verbosity_value_saved

@gmcculloug @syncrou please review/test

@h-kataria h-kataria requested a review from gmcculloug June 6, 2017 14:58
@gmcculloug
Copy link
Member

@syncrou Please review

syncrou
syncrou reviewed Jun 6, 2017
View reviewed changes
app/assets/javascripts/controllers/catalog/catalog_item_form_controller.js
@@ -70,6 +73,17 @@ ManageIQ.angular.app.controller('catalogItemFormController', ['$scope', 'catalog
}
};

var getVerbosityTypes = function() {
vm['verbosity_types'] = {
Copy link
Contributor

@syncrou syncrou Jun 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-kataria - Is there a way this list can be built dynamically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syncrou currently Angular forms are being populated using API calls, but we don't have back-end or API support to get a list of Verbosity types at the moment so i have hard coded this list for now.

@syncrou
Copy link
Contributor

syncrou commented Jun 6, 2017 •
edited
Loading

@h-kataria - I ran tests using the following scenarios:

  1. Add an Ansible Playbook catalog item (only provision playbook) set verbosity to 3 - Passed
  2. Edit the Catalog Item - Add retirement playbook - copy from provision - Failed (Verbosity doesn't copy over)
  3. Edit the Catalog Item - Modify both the retirement and provision verbosity levels to different values - Passed

syncrou
syncrou approved these changes Jun 6, 2017
View reviewed changes
Copy link
Contributor

@syncrou syncrou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - Ran tests with the additional changes. Copy from Provisioning worked as expected.

Looks good to me when green.

@gmcculloug
Copy link
Member

@h-kataria This is a required field for JobTemplates and defaults to 0 - (Normal). Can we drop the "Choose" option and default it to 0 as well?

Also, will existing catalog items, created before this change, show the 0 - (Normal) logging level?

@h-kataria
Copy link
Contributor Author

@gmcculloug i will make the suggested change, currently it shows 0 (Normal) logging level for existing Catalog Items.

@h-kataria h-kataria added the wip label Jun 8, 2017
@h-kataria h-kataria changed the title Added Verbosity drop down on both Provisioning & Retirement tabs [WIP] - Added Verbosity drop down on both Provisioning & Retirement tabs Jun 8, 2017
@h-kataria
Added Verbosity drop down on both Provisioning & Retirement tabs
7d6e23d 
- Added new 'Verbosity' drop down on Playbook catalog item form and summary screen to display saved Verbosity field values.
- Added/Updated spec tests to verify changes

https://www.pivotaltracker.com/n/projects/1613907/stories/146545759
@h-kataria
Copy link
Contributor Author

@gmcculloug made suggested changes, please re-review

@h-kataria h-kataria changed the title [WIP] - Added Verbosity drop down on both Provisioning & Retirement tabs Added Verbosity drop down on both Provisioning & Retirement tabs Jun 8, 2017
@h-kataria h-kataria removed the wip label Jun 8, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 8, 2017

Checked commit h-kataria@7d6e23d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐

gmcculloug
gmcculloug approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@dclarizio dclarizio merged commit af2c4aa into ManageIQ:master Jun 8, 2017
@dclarizio dclarizio added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 8, 2017
@simaishi
Copy link
Contributor

@h-kataria Is there a BZ for this? Can you please create one if it doesn't exist?

@h-kataria
Copy link
Contributor Author

@simaishi created BZ for Fine backport: https://bugzilla.redhat.com/show_bug.cgi?id=1460788

simaishi pushed a commit that referenced this pull request Jun 12, 2017
@simaishi
Merge pull request #1493 from h-kataria/ansible_playbook_verbosity
c04a63c 
Added Verbosity drop down on both Provisioning & Retirement tabs
(cherry picked from commit af2c4aa)

https://bugzilla.redhat.com/show_bug.cgi?id=1460809
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c04a63c365b3a93a7918ed6721d44f51f0b11d2a
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Jun 8 12:37:34 2017 -0700

    Merge pull request #1493 from h-kataria/ansible_playbook_verbosity
    
    Added Verbosity drop down on both Provisioning & Retirement tabs
    (cherry picked from commit af2c4aa25e2380da772f160fca8f5f410c592639)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460809

@h-kataria h-kataria deleted the ansible_playbook_verbosity branch June 22, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syncrou syncrou syncrou approved these changes

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@dclarizio dclarizio

Labels
automation/ansible enhancement fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@h-kataria @gmcculloug @syncrou @miq-bot @simaishi @dclarizio