Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tags to Ansible Tower Provider and Foreman Provider #1534

Merged
merged 5 commits into from
Jun 26, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Jun 13, 2017

Add logic to add toolbar button Edit Tags and Tag assignement screen for Ansible Tower Provider and Foreman Provider.

Waiting for ManageIQ/manageiq#15437

Toolbar after:
screen shot 2017-06-13 at 2 08 20 pm
screen shot 2017-06-13 at 2 07 54 pm

Tag Assignment Ansible Tower Provider:
screen shot 2017-06-23 at 12 06 43 pm

Tag Assignment Foreman Provider:
screen shot 2017-06-23 at 12 06 02 pm

@miq-bot add_label bug, automation/ansible, wip

https://bugzilla.redhat.com/show_bug.cgi?id=1436846

TODO:

  • Toolbar button
  • Tag Assignment screen render
  • Save
  • Reset
  • Cancel

@miq-bot miq-bot changed the title Add Tags to Ansible Tower Provider [WIP] Add Tags to Ansible Tower Provider Jun 13, 2017
Add logic to add toolbar button Edit Tags and Tag assignement screen for Ansible Tower Provider
@ZitaNemeckova ZitaNemeckova force-pushed the tag_ansible branch 2 times, most recently from 986905e to f1b1c61 Compare June 23, 2017 09:40
@ZitaNemeckova ZitaNemeckova changed the title [WIP] Add Tags to Ansible Tower Provider [WIP] Add Tags to Ansible Tower Provider and Foreman Provider Jun 23, 2017
CM_X_BUTTON_ALLOWED_ACTIONS is never called
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label pending core

@miq-bot
Copy link
Member

miq-bot commented Jun 23, 2017

Checked commits ZitaNemeckova/manageiq-ui-classic@2adb902~...efbf1ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
12 files checked, 15 offenses detected

app/helpers/application_helper/toolbar/automation_manager_provider_center.rb

  • ❗ - Line 36, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 38, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 48, Col 26 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 51, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/automation_manager_providers_center.rb

  • ❗ - Line 53, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 55, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 70, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 71, Col 29 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 74, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/configuration_manager_provider_center.rb

  • ❗ - Line 35, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 45, Col 26 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 48, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/configuration_manager_providers_center.rb

  • ❗ - Line 52, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 66, Col 29 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 69, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Add Tags to Ansible Tower Provider and Foreman Provider Add Tags to Ansible Tower Provider and Foreman Provider Jun 23, 2017
@miq-bot miq-bot removed the wip label Jun 23, 2017
@martinpovolny martinpovolny merged commit 2425f59 into ManageIQ:master Jun 26, 2017
@martinpovolny martinpovolny added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 26, 2017
@ZitaNemeckova ZitaNemeckova deleted the tag_ansible branch September 12, 2017 14:20
@lgalis
Copy link
Contributor

lgalis commented Nov 20, 2017

@ZitaNemeckova , @martinpovolny - I see no specs on this. Was the plan to add them later on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants