Do not run move of new pagination and remove of old one when new one is present #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@skateman this fixes the bug we were talking about, please review and check if it is OK. |
|
I was testing it and found out a strange behavior. If you remove an element (did with the last one on the last page), the whole paginator breaks and stops working... |
karelhala
force-pushed
the
missingPagination
branch
from
8cf2ad2
to
bcfed18
Compare
karelhala
force-pushed
the
missingPagination
branch
from
bcfed18
to
d87a564
Compare
karelhala
force-pushed
the
missingPagination
branch
from
d87a564
to
30937e3
Compare
|
@karelhala I think the cc issue is an easy fix . . . I will try this out in the meantime. |
…is present When more than one pagination in angular is present remove left overs
karelhala
force-pushed
the
missingPagination
branch
from
30937e3
to
a362564
Compare
|
Checked commits karelhala/manageiq-ui-classic@e1fa9be~...a362564 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Fixed --> merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Merge of c0feb50 there was bug when new pagination was present it was removed if page/sorting has changed. So do not run removing of pagination and moving such pagination if new one is already at correct place.
Fixes #1489