Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating IPs: Fix edit form buttons #1582

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Floating IPs: Fix edit form buttons #1582

merged 1 commit into from
Jun 22, 2017

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jun 22, 2017

Declares the edit form to the controller vm scope
Replaces with the generic_form_buttons

https://bugzilla.redhat.com/show_bug.cgi?id=1463970

Declare the edit form to the controller vm scope
Replaces with the generic_form_buttons

https://bugzilla.redhat.com/show_bug.cgi?id=1463970
@gildub gildub mentioned this pull request Jun 22, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 22, 2017

Checked commit https://github.com/gildub/manageiq-ui-classic/commit/9d9187167eee515a0bfaaad48911e228db6064bd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@gildub
Copy link
Contributor Author

gildub commented Jun 22, 2017

@dclarizio, @martinpovolny, could you please take care of it? Do you think it could make it for Fine release this week if it's a good candidate enough ?

@gildub gildub mentioned this pull request Jun 22, 2017
@ZitaNemeckova
Copy link
Contributor

Fixes error in #791 that was backported to Fine.

@martinpovolny martinpovolny merged commit 16f257c into ManageIQ:master Jun 22, 2017
@martinpovolny martinpovolny added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 22, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit a9ea4ad7f2efcfec6b6f3f793149eef4cc63a593
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Jun 22 15:25:32 2017 +0200

    Merge pull request #1582 from gildub/floating_ips-fix-edit-scope
    
    Floating IPs: Fix edit form buttons
    (cherry picked from commit 16f257cece3ec7a217fd0f9728f6adf55e5057a2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1464153

simaishi pushed a commit that referenced this pull request Jun 22, 2017
@gildub gildub deleted the floating_ips-fix-edit-scope branch June 23, 2017 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants