Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PDF download button for persistent volume #1624

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Fix PDF download button for persistent volume #1624

merged 1 commit into from
Jun 29, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Jun 28, 2017 •
edited
Loading

@zakiva
Copy link
Contributor Author

zakiva commented Jun 28, 2017

@miq-bot add_label compute/containers, bug

@zakiva
Copy link
Contributor Author

zakiva commented Jun 28, 2017

@simon3z @moolitayer @himdel Please review

@moolitayer
Copy link

moolitayer commented Jun 28, 2017 •
edited
Loading

Interesting 🙃 - did you find out how come this worked in development but not in production+productization? (was it something unrelated to env?)

@miq-bot
Copy link
Member

miq-bot commented Jun 28, 2017

Checked commit zakiva@4a84199 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@zakiva
Copy link
Contributor Author

zakiva commented Jun 28, 2017 •
edited
Loading

Interesting - did you find out how come this worked in development but not in production+productization?

It actually wouldn't work in dev either, the thing is that these PDF download buttons (for all entities) exist only in productization. I did'nt find how exactly they are added, but I verified this fix with a productization appliance.

moolitayer
moolitayer approved these changes Jun 29, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
cc @dclarizio

@moolitayer
Copy link

@miq-bot add_label fine/yes

@dclarizio dclarizio self-assigned this Jun 29, 2017
@dclarizio
Copy link

@zakiva if you install Prince PDF on your dev server, you will get the PDF button. If it's not licensed, the PDF will have a watermark, but that's fine for testing. Thanks for the fix!

@dclarizio dclarizio merged commit e963e32 into ManageIQ:master Jun 29, 2017
@dclarizio dclarizio added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 29, 2017
simaishi pushed a commit that referenced this pull request Aug 4, 2017
@simaishi
Merge pull request #1624 from zakiva/fix_pdf
e8295db 
Fix PDF download button for persistent volume
(cherry picked from commit e963e32)

https://bugzilla.redhat.com/show_bug.cgi?id=1478406
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit e8295dbab84c788f721e7e48712ff5a5baeceda8
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Jun 29 06:53:09 2017 -0700

    Merge pull request #1624 from zakiva/fix_pdf
    
    Fix PDF download button for persistent volume
    (cherry picked from commit e963e32a807aa6b99d37accfc060bb767c00c1d9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moolitayer moolitayer moolitayer approved these changes

Assignees

@dclarizio dclarizio

Labels
bug compute/containers fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zakiva @moolitayer @miq-bot @dclarizio @simaishi