Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] Fix search on the topology screens #1659

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Jul 7, 2017

The search mixin introduced in #1277 was depending on #955 that wasn't backported. This broke the search on topology screens in the fine release. As #955 is too complex for backporting, I made a set of small fixes that should make the search work again.

@miq-bot add_label bug, fine/yes, topology
@miq-bot assign @himdel

https://bugzilla.redhat.com/show_bug.cgi?id=1465346

@miq-bot
Copy link
Member

miq-bot commented Jul 7, 2017

Checked commit skateman@6acb87b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@simaishi simaishi requested a review from himdel July 7, 2017 20:47
@simaishi simaishi assigned simaishi and unassigned himdel Jul 7, 2017
@simaishi simaishi added blocker and removed fine/yes labels Jul 7, 2017
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simaishi simaishi merged commit c53bfe1 into ManageIQ:fine Jul 10, 2017
@simaishi simaishi added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 10, 2017
@skateman skateman deleted the bz-1465346 branch July 10, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants