ReportController - replace_right_cell - don't rebuild trees which don't exist #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t exist Check if a tree exists before rebuilding it. Related to https://bugzilla.redhat.com/show_bug.cgi?id=1468336 (comment #4)
himdel
changed the title
tree_exists expects the whole tree name, including _tree
* moved the common code to `before` * removed obsolete x_build_dyna_tree mention * don't overwrite @sb by calling contoller.instance_variable_set twice * pre-initialize all the trees - otherwise tree_exists? won't find them * also test `build_reports_tree`, especially in the one test that was supposed to check it gets re-rendered when explicitly called with `:replace_trees` * add a spec testing only existing trees get rendered
|
LGTM |
simaishi
pushed a commit
that referenced
this pull request
Jul 10, 2017
ReportController - replace_right_cell - don't rebuild trees which don't exist (cherry picked from commit 831a078) https://bugzilla.redhat.com/show_bug.cgi?id=1468336
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if a tree exists before rebuilding it.
(The trees get rebuilt when a new report is generated, but we need to rebuild only the ones that the user can see, not all of them.)
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1468336 (comment #4), and thus a follow-up to #1657 .
Steps to reproduce...
(before, you'll see an infinite spinner, after, it should work :))
Ping @h-kataria :)