Toolbar refactoring: Buttons ending with _new or _discover

[vecerek]

Button classes created:

Toolbar button ids	Toolbar button classes created
arbitration_profile_new, cloud_network_new, cloud_tenant_new, condition_new, ab_group_new, ems_cloud_new, ems_container_new, ems_datawarehouse_new, ems_infra_new, ems_middleware_new, host_aggregate_new, host_miq_request_new, host_new, host_miq_request_new, iso_datastore_new, action_new, alert_profile_new, alert_new, old_dialogs_new, policy_new, profile_new, db_new, network_router_new, persistent_volume_new, pxe_image_type_new, pxe_server_new, security_group_new, st_catalog_new, atomic_catalogitem_new, catalogitem_new, storage_manager_new, image_miq_request_new, miq_template_miq_request_new, timeprofile_new, vm_miq_request_new, zone_new, ems_cloud_discover, ems_infra_discover, host_discover	ButtonNewDiscover < Basic
dialog_new	DialogNew < DialogAction
ems_network_new	EmsNetworkNew < EmsNetwork
miq_ae_domain_new	MiqAeDefaultNoRecordNew < MiqAeDefault
miq_ae_namespace_new, miq_ae_instance_new, miq_ae_method_new, miq_ae_namespace_new, miq_ae_class_new	MiqAeNew < MiqAeDefault
miq_report_new	MiqReportNew < MiqReportAction
miq_template_miq_request_new, image_miq_request_new	MiqTemplateMiqRequestNew < GenericFeatureButtonWithDisable
ab_group_new, ab_button_new,	CatalogItemButtonNew < CatalogItemButton

Button class hierarchy edited:

From	To
AbButtonNew < Basic	AbButtonNew < ButtonNewDiscover
AuthKeyPairCloudCreate < Basic	AuthKeyPairCloudCreate < ButtonNewDiscover
ChargebackRates < Basic	ChargebackRates < ButtonNewDiscover
CloudSubnetNew < Basic	CloudSubnetNew < ButtonNewDiscover
CloudVolumeNew < Basic	CloudVolumeNew < ButtonNewDiscover
InstanceMiqRequestNew < Basic	InstanceMiqRequestNew < ButtonNewDiscover
VmMiqRequestNew < Basic	VmMiqRequestNew < ButtonNewDiscover
WidgetNew < Basic	WidgetNew < ButtonNewDiscover

Links

Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/136441199
Original PR: ManageIQ/manageiq#13281

[miq-bot]

@vecerek Cannot apply the following label because they are not recognized: ui

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[vecerek]

@romanblanco @PanSpagetka could you review, pls?

[vecerek]

@miq-bot remove_label wip

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[romanblanco]

@vecerek please rebase

[romanblanco]

@vecerek Shouldn't this be removed with adding DialogNew button?

[romanblanco]

Nevermind, I think I understand now, (thanks @PanSpagetka)

[vecerek]

@romanblanco without this condition, the #hide_button? method would return true for all the dialog buttons thus skipping the call of their #visible? method.

[romanblanco]

@vecerek Seems like your changes are breaking the Automate area:

I'm getting issues by clicking in Automate -> Customization:

[----] F, [2017-02-27T15:38:40.045167 #16311:2ada037320a0] FATAL -- : Error caught: [NoMethodError] undefined method `decorate' for MiqAeNamespaceDecorator:Class
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:18:in `decorate'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_node/miq_ae_namespace.rb:10:in `block in <class:MiqAeNamespace>'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_node/node.rb:37:in `instance_eval'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_node/node.rb:37:in `block (2 levels) in set_attributes'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_node/node.rb:123:in `to_h'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:280:in `x_build_single_node'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:257:in `x_build_node'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:267:in `block in x_build_node'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:266:in `map'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:266:in `x_build_node'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:287:in `x_build_node_tree'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:212:in `block in x_build_tree'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.1/lib/active_record/relation/delegation.rb:38:in `map'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.1/lib/active_record/relation/delegation.rb:38:in `map'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:207:in `x_build_tree'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:142:in `build_tree'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder.rb:26:in `initialize'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/presenters/tree_builder_automate.rb:8:in `initialize'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller.rb:468:in `new'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller.rb:468:in `build_ae_tree'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/miq_ae_customization_controller.rb:220:in `replace_right_cell'

or

[----] F, [2017-02-27T15:45:57.576122 #22492:2b0b30583f0c] FATAL -- : Error caught: [Draper::UninferrableDecoratorError] Could not infer a decorator for ActiveRecord::Base.
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:81:in `rescue in decorator_class'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:73:in `decorator_class'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:78:in `rescue in decorator_class'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:73:in `decorator_class'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:78:in `rescue in decorator_class'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:73:in `decorator_class'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:23:in `decorator_class'
/home/rblanco/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/draper-3.0.0.pre1/lib/draper/decoratable.rb:18:in `decorate'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller.rb:980:in `listicon_image'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller.rb:879:in `block in view_to_hash'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller.rb:866:in `each'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller.rb:866:in `view_to_hash'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller.rb:1591:in `get_view'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/miq_ae_customization_controller/dialogs.rb:87:in `dialog_list'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/miq_ae_customization_controller/dialogs.rb:1384:in `dialog_get_node_info'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/miq_ae_customization_controller.rb:275:in `get_specific_node_info'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/miq_ae_customization_controller.rb:264:in `get_node_info'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/miq_ae_customization_controller.rb:103:in `accordion_select'

Rebasing didn't help.

Seems to happen after changes in c84f8e1

UPDATE: should be fixed by merging ManageIQ/manageiq#14044.

[PanSpagetka]

Reviewed from action_new to the end in UI, seems to be OK so far, continue tomorrow

[PanSpagetka]

After million years I clicked through this and didn't find anything wrong. So for me, It looks good 👍 @romanblanco ?

[miq-bot]

Checked commits vecerek/manageiq-ui-classic@d6817e6~...eb40b66 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
72 files checked, 54 offenses detected

app/helpers/application_helper/toolbar/arbitration_profiles_center.rb

• ❗ - Line 14, Col 78 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 22, Col 41 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 32, Col 42 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 36, Col 15 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.

app/helpers/application_helper/toolbar/catalogitem_button_set_center.rb

• ❗ - Line 14, Col 68 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 20, Col 68 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/catalogitem_buttons_center.rb

• ❗ - Line 21, Col 68 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/cloud_networks_center.rb

• ❗ - Line 16, Col 67 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/cloud_tenants_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/conditions_center.rb

• ❗ - Line 22, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/custom_button_set_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/dialogs_center.rb

• ❗ - Line 14, Col 57 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_cloud_center.rb

• ❗ - Line 40, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_clouds_center.rb

• ❗ - Line 25, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 33, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_containers_center.rb

• ❗ - Line 25, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_datawarehouses_center.rb

• ❗ - Line 25, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_infras_center.rb

• ❗ - Line 25, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 33, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_middlewares_center.rb

• ❗ - Line 25, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_networks_center.rb

• ❗ - Line 25, Col 61 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/host_aggregates_center.rb

• ❗ - Line 15, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/hosts_center.rb

• ❗ - Line 166, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 76, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 84, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/iso_datastores_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_actions_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_ae_domain_center.rb

• ❗ - Line 46, Col 56 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_ae_domains_center.rb

• ❗ - Line 14, Col 71 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_ae_instances_center.rb

• ❗ - Line 35, Col 56 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_ae_methods_center.rb

• ❗ - Line 35, Col 56 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_ae_namespace_center.rb

• ❗ - Line 28, Col 56 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 34, Col 56 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_alert_profiles_center.rb

• ❗ - Line 16, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_alerts_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_dialogs_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_policies_center.rb

• ❗ - Line 20, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_policy_profiles_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_report_center.rb

• ❗ - Line 22, Col 60 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_reports_center.rb

• ❗ - Line 14, Col 60 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/miq_widget_sets_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/persistent_volumes_center.rb

• ❗ - Line 17, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/pxe_image_types_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/pxe_servers_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/security_groups_center.rb

• ❗ - Line 16, Col 67 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/servicetemplatecatalogs_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/servicetemplates_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 20, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/storage_managers_center.rb

• ❗ - Line 34, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/template_clouds_center.rb

• ❗ - Line 98, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/template_infras_center.rb

• ❗ - Line 126, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/time_profiles_center.rb

• ❗ - Line 15, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/vms_center.rb

• ❗ - Line 117, Col 69 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/zones_center.rb

• ❗ - Line 14, Col 65 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

[romanblanco]

@vecerek LGTM now 👍
@miq-bot assign @martinpovolny