Enablement and Visibility expression UI for custom buttons

[martinpovolny]

Rebase of #1739

I had to merge @skateman's #1685 because the model changes are already in and this broke @lgalis 's PR #1739 that I am reviewing.

[martinpovolny]

$ grep -r adv_search_flash app/
app/views/layouts/_adv_search_body.html.haml:    = render :partial => 'layouts/flash_msg', :locals => {:flash_div_id => 'adv_search_flash'}
app/views/layouts/_adv_search_body.html.haml:      = render :partial => 'layouts/flash_msg', :locals => {:flash_div_id => 'adv_search_flash'}

Does this change break the other places where we use the expression editor?

[martinpovolny]

Yeah so this actually breaks the expression editor inside the advanced search.

1. Go to Compute --> Infra --> VM --> actually select the VMs accordion
2. Open the advanced search (arrow next to search field)
3. Add in a field, but do not select what to do with that field (create an un-complete expression)
4. press the "✓" symbol

A flash message should appear in the expresion editor, but it is actually sent to the flash_msg_div below the opened modal.

[lpichler]

I tested it and expression and display text are stored correctly 👍

Only maybe there is some issue with styling (I think that there is the bigger font but I am not sure):

[lpichler]

tested 👍 saving the form with various values (empty,... )

[martinpovolny]

Review notice: the UI is just ugly. We need to fix that in some future PRs. Ping @epwinchell ? Please?

[dclarizio]

@martinpovolny I know you were fixing some bugs, let us know when this is ready.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits martinpovolny/manageiq-ui-classic@6c3ac3b~...a6bdb57 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
16 files checked, 0 offenses detected
Everything looks fine. 🍰

[martinpovolny]

The bug I was fixing: (c-n-ped from above):

Yeah so this actually breaks the expression editor inside the advanced search.

1. Go to Compute --> Infra --> VM --> actually select the VMs accordion
2. Open the advanced search (arrow next to search field)
3. Add in a field, but do not select what to do with that field (create an un-complete expression)
4. press the "✓" symbol

A flash message should appear in the expresion editor, but it is actually sent to the flash_msg_div below the opened modal.

962b778 should fix that. Please, test and merge.

The form design is pretty ugly, but we can surely work on that in a separate PR.

[epwinchell]

The form design is pretty ugly, but we can surely work on that in a separate PR.

@martinpovolny agreed

[h-kataria]

Tested in UI other than styling issues, looks good.