Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter custom buttons according to visibility expressions #1824

Merged
merged 2 commits into from
Aug 25, 2017
Merged

Filter custom buttons according to visibility expressions #1824

merged 2 commits into from
Aug 25, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Aug 3, 2017

  • works for lists and for summary screens

behaviors

summary screens

  • if visibility expression is not set it means that button will be displayed
  • if visibility expression set then it is evaluated for the object(Vm,...) of the summary page

lists

  • if all visibility expressions are not set in custom buttons then buttons are displayed
  • if any visibility expression is set in custom buttons then all buttons are not displayed

Links

backend pending: ManageIQ/manageiq#15725
first part of https://www.pivotaltracker.com/story/show/147780767 - visibility of custom buttons

@lpichler
Copy link
Contributor Author

lpichler commented Aug 3, 2017 •
edited
Loading

@miq-bot add_label enhacement, backend_pending
@miq-bot assign @martinpovolny
cc @gtanzillo

@lpichler lpichler mentioned this pull request Aug 3, 2017
Merged
@miq-bot miq-bot added the wip label Aug 3, 2017
@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2017

@lpichler Cannot apply the following labels because they are not recognized: enhacement, backend_pending

@lpichler lpichler changed the title [WIP] Filter custom buttons according to visibility expressions Filter custom buttons according to visibility expressions Aug 9, 2017
@miq-bot miq-bot removed the wip label Aug 9, 2017
@martinpovolny
Copy link
Member

ping @lpichler : please, fix the specs

@lpichler lpichler closed this Aug 22, 2017
@lpichler lpichler reopened this Aug 22, 2017
@lpichler
Copy link
Contributor Author

@martinpovolny fixed

@miq-bot
Copy link
Member

miq-bot commented Aug 22, 2017

Checked commits lpichler/manageiq-ui-classic@e48a543~...3f46a60 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 25, 2017
@martinpovolny martinpovolny merged commit bd47da3 into ManageIQ:master Aug 25, 2017
@lpichler lpichler deleted the filter_custom_buttons branch August 25, 2017 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
automation/automate enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpichler @miq-bot @martinpovolny