Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct db value for Provider Foreman case #1847

Merged

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Aug 7, 2017

Fix for the error below on a Provider Foreman page -

F, [2017-08-07T12:14:07.262478 #36969] FATAL -- : Error caught: [ActionController::UrlGenerationError] No route matches {:action=>"show", :controller=>"ems_configuration", :id=>"29"}
~/.rvm/gems/ruby-2.4.1/gems/actionpack-5.0.5/lib/action_dispatch/journey/formatter.rb:51:in `generate'
~/.rvm/gems/ruby-2.4.1/gems/actionpack-5.0.5/lib/action_dispatch/routing/route_set.rb:631:in `generate'
~/.rvm/gems/ruby-2.4.1/gems/actionpack-5.0.5/lib/action_dispatch/routing/route_set.rb:662:in `generate'
~/.rvm/gems/ruby-2.4.1/gems/actionpack-5.0.5/lib/action_dispatch/routing/route_set.rb:709:in `url_for'
~/.rvm/gems/ruby-2.4.1/gems/actionpack-5.0.5/lib/action_dispatch/routing/url_for.rb:172:in `url_for'
~/.rvm/gems/ruby-2.4.1/gems/actionview-5.0.5/lib/action_view/routing_url_for.rb:90:in `url_for'
~/manageiq/plugins/manageiq-ui-classic/app/helpers/application_helper.rb:17:in `url_for_only_path'
~/manageiq/plugins/manageiq-ui-classic/app/helpers/application_helper.rb:313:in `url_for_db'
~/manageiq/plugins/manageiq-ui-classic/app/helpers/application_helper.rb:293:in `url_for_record'
~/manageiq/plugins/manageiq-ui-classic/app/helpers/quadicon_helper.rb:643:in `render_non_listicon_single_quadicon'
~/manageiq/plugins/manageiq-ui-classic/app/helpers/quadicon_helper.rb:693:in `render_single_quad_quadicon'
~/manageiq/plugins/manageiq-ui-classic/app/helpers/quadicon_helper.rb:163:in `quadicon_builder_factory'
~/manageiq/plugins/manageiq-ui-classic/app/helpers/quadicon_helper.rb:150:in `block in render_quadicon'

Closes #1858

@AparnaKarve
Copy link
Contributor Author

AparnaKarve commented Aug 7, 2017

Not sure what changed between last week and today, since I don't recollect seeing this error last week.

EDIT: While this fix is perfectly valid (and harmless), we did not need it before, so my gut feeling is that it might be masking a bigger issue.
Also, a similar error is seen while trying to access http://localhost:3000/miq_ae_customization/explorer

/cc @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2017

Checked commit AparnaKarve@1f6221d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@AparnaKarve
Copy link
Contributor Author

@himdel @martinpovolny Should we be suspecting the webpack PR for this anomalous behavior?
Other recently merged PRs look fairly innocent.
WDYT?

@himdel
Copy link
Contributor

himdel commented Aug 9, 2017

Little chance this has anything to do with webpack, could be some provider change.

Anyway, your fix looks good to me, @karelhala WDYT?

@karelhala
Copy link
Contributor

@himdel @AparnaKarve this fix looks good. I think we can merge this, however I am amazed that it was not visible last week and now it is. Strange...

@himdel himdel self-assigned this Aug 9, 2017
@himdel himdel added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 9, 2017
@himdel himdel merged commit 6508d6a into ManageIQ:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants