Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network provider fields #1862

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Network provider fields #1862

merged 1 commit into from
Aug 16, 2017

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Aug 9, 2017 •
edited
Loading

Adds physical and segmentation id fields to support creation a network provider.
Makes provider_network_type not required, because the network to use default backend anyway.
Also re-factors using Object.assign

networ-providers

https://bugzilla.redhat.com/show_bug.cgi?id=1481696

@miq-bot miq-bot added the wip label Aug 9, 2017
@tzumainn
Copy link
Contributor

Hi! Thanks for the PR, just one quick question - it looks like the commit list has some pretty old commits. Is that correct?

@gildub
Copy link
Contributor Author

gildub commented Aug 14, 2017

@tzumainn, that's right those commits belongs to dependant #1516. I'll clear them once the latter has been merged which should happen very soon. Thanks

@miq-bot
Copy link
Member

miq-bot commented Aug 15, 2017

This pull request is not mergeable. Please rebase and repush.

@gildub gildub changed the title [WIP] Network provider fields Network provider fields Aug 15, 2017
@miq-bot miq-bot removed the wip label Aug 15, 2017
@gildub gildub closed this Aug 15, 2017
@gildub gildub reopened this Aug 15, 2017
@miq-bot
Copy link
Member

miq-bot commented Aug 15, 2017

Checked commit https://github.com/gildub/manageiq-ui-classic/commit/59a9b1bb6720940635608dbf4c9d15bcd48bff21 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@tzumainn
Copy link
Contributor

I've tested this PR, works great!

@tzumainn
Copy link
Contributor

@miq-bot add_label fine/yes,bug

@tzumainn tzumainn mentioned this pull request Aug 15, 2017
Merged
@mzazrivec mzazrivec self-assigned this Aug 16, 2017
@mzazrivec mzazrivec added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 16, 2017
@mzazrivec mzazrivec merged commit f24b0ba into ManageIQ:master Aug 16, 2017
@gildub gildub deleted the network_provider_fields branch August 17, 2017 02:03
simaishi pushed a commit that referenced this pull request Aug 17, 2017
@mzazrivec @simaishi
Merge pull request #1862 from gildub/network_provider_fields
6eb3e26 
Network provider fields
(cherry picked from commit f24b0ba)

https://bugzilla.redhat.com/show_bug.cgi?id=1482136
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 6eb3e26842a511f911652434fefdcb0ac8431229
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Aug 16 12:00:46 2017 +0200

    Merge pull request #1862 from gildub/network_provider_fields
    
    Network provider fields
    (cherry picked from commit f24b0ba99f45a9795744ad1fe698b07bd74d991f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1482136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug enhancement fine/backported networks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gildub @tzumainn @miq-bot @simaishi @mzazrivec