Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report data api per page #1864

Merged
merged 3 commits into from
Aug 9, 2017

Conversation

karelhala
Copy link
Contributor

This is improvement for QE report data (GTL) API, new method, bug fixes and improvements.

New method:

  • (stores) sendDataWithRx({controller: 'reportDataController', action: 'is_displayed', data: ['name_or_id']}) data name_or_id can be number or string, since simple comparison (==) is used.
    Will query for item based on name or it's ID property. It will store either true or false in result object.

Bug fixes:

  1. perevious_page - typo [FIXED]
  2. set_sorting takes number not name - [FIXED], new set_sorting: sendDataWithRx({controller: 'reportDataController', action: 'set_sorting', data: [{columnName: 'Name', isAscending: true}]})
  3. set_sorting doesn't change sorting - [FIXED] wit previous point
  4. check/uncheck all work not thru pagination pane (pagination page checkbox isn't updated) - desired behavior
  5. set_items_per_page sets incorrect value when it is called not on first page - [FIXED]
  6. first/next/previous/last/go_to_page don't work - [FIXED]

Improvements

If someone will call for get_item or get_all_items result item will now have cells as object with key and value, instead of array of object's value.

{
  item: {
    "cells":{  
         "Name":"dell-r420-01.cloudforms.lab.eng.rdu2.redhat.com",
         "IP Addres": "0.0.0.0",
         "Cluster":"Default",
         "Total VMs":"1",
         "Total Templates":"0",
         "Platform":"rhel",
         "Version":"",
      },
      id:"12",
      long_id:12,
      img_url: "some/path",
      quadicon: "htmlObject"
  }
}

@karelhala
Copy link
Contributor Author

@miq-bot add_label enhancement

@karelhala
Copy link
Contributor Author

@izapolsk these are the improvements and bug fixes you found.

@izapolsk
Copy link

izapolsk commented Aug 9, 2017

@karelhala , many thanks !

@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2017

Checked commits karelhala/manageiq-ui-classic@95d568d~...28a4464 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 9, 2017
@martinpovolny martinpovolny merged commit 1629c5b into ManageIQ:master Aug 9, 2017
@martinpovolny martinpovolny self-assigned this Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants