Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2v: Move Transform button to "Lifecycle" group #1878

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

matobet
Copy link
Contributor

@matobet matobet commented Aug 10, 2017

@matobet
Copy link
Contributor Author

matobet commented Aug 10, 2017

@miq-bot assign @himdel

@matobet
Copy link
Contributor Author

matobet commented Aug 10, 2017

@miq-bot add_label fine/yes

@miq-bot
Copy link
Member

miq-bot commented Aug 10, 2017

Checked commit matobet@88c80b7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@himdel himdel merged commit 58b9096 into ManageIQ:master Aug 11, 2017
@himdel
Copy link
Contributor

himdel commented Aug 11, 2017

Moves the button from Configuration to Lifecycle 👍
And it is the only toolbar with this button.. LGTM :)

@himdel himdel added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 11, 2017
simaishi pushed a commit that referenced this pull request Aug 11, 2017
v2v: Move Transform button to "Lifecycle" group
(cherry picked from commit 58b9096)

https://bugzilla.redhat.com/show_bug.cgi?id=1480588
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit e04f74250fcb380bf50031da58581fcbc9c6cf95
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Aug 11 11:13:26 2017 +0000

    Merge pull request #1878 from matobet/v2v-button-move
    
    v2v: Move Transform button to "Lifecycle" group
    (cherry picked from commit 58b90960478d940e4553cab3a1ee306df8d2bd28)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1480588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants