Use class variable gtl_type to check type of report, this way we will receive correct report type #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… receive correct report type
|
@karelhala Cannot apply the following label because they are not recognized: gtls |
|
Checked commit karelhala@8de822f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 both places with quadicons and places without them seem to work now |
This was referenced Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1885
In previous PR #1867 there was a mistake where we checked GTL type by calling
get_view_calculate_gtl_type, however this function will return alwayslistwhen called later on. However we have class variable which is calledgtl_typethis variable stores correct type.