Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify correct features names in Block/Object Storage toolbar button actions #1908

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Aug 14, 2017

Depends on ManageIQ/manageiq#15812

In the ems code, the delete and refresh operations are invoked based on the following condition -

deleteemss if params[:pressed] == "#{table_name}_delete"
refreshemss if params[:pressed] == "#{table_name}_refresh"

Therefore, feature names for delete and refresh must be based off the current table name

For e.g. ems_block_storage_refresh should be specified in the toolbar button action as opposed to ems_storage_refresh in order for the button action to execute.

Before:
screen shot 2017-08-14 at 2 49 48 pm

After:
screen shot 2017-08-14 at 2 48 22 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1440114

@miq-bot
Copy link
Member

miq-bot commented Aug 14, 2017

Checked commits AparnaKarve/manageiq-ui-classic@e46440e~...cd8fd1f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny martinpovolny merged commit c7d76a1 into ManageIQ:master Aug 30, 2017
@martinpovolny martinpovolny added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 30, 2017
simaishi pushed a commit that referenced this pull request Nov 13, 2017
…rage_features

Specify correct features names in Block/Object Storage toolbar button actions
(cherry picked from commit c7d76a1)

https://bugzilla.redhat.com/show_bug.cgi?id=1496904
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 1f9b0feefb225336e11b248438b154dd5a603b39
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Aug 30 11:05:16 2017 +0200

    Merge pull request #1908 from AparnaKarve/bz1440114_state_correct_storage_features
    
    Specify correct features names in Block/Object Storage toolbar button actions
    (cherry picked from commit c7d76a1be98fb0efcac7cdb52816a4278d7aa817)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants