Changed label "Location" to "Type", made field read-only after selection #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed code to make Type as read only field once user selects the type of Add new method screen. Type field will be read only field on Edit Method screen. https://www.pivotaltracker.com/story/show/149747321
|
@h-kataria since we're now locking the Type, we should put that up top all by itself, then show the rest of the form once the user selects it. That will make it more obvious that it can't be changed once selected. |
|
@dclarizio please review addressed feedback, made it work like Catalog Item editor where we allow user to select Type first and then show the form. |
|
@h-kataria might as well keep the Type on top of the form after is it chosen, for consistency. |
Changed to allow user to select Type first, display rest of the form after user makes type selection. https://www.pivotaltracker.com/story/show/149747321
h-kataria
force-pushed
the
tie_down_type_field_in_method_editor
branch
from
f844af5
to
d10a4a4
Compare
|
@dclarizio moved Type field to the top of form/summary screen to be consistent. |
|
Checked commits h-kataria/manageiq-ui-classic@44b09a9~...d10a4a4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/miq_ae_class/_method_form.html.haml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed code to make Type as read only field once user selects the type of Add new method screen. Type field will be read only field on Edit Method screen.
https://www.pivotaltracker.com/story/show/149747321
@dclarizio please review.
before:
after:
