Introducing a controller that returns automate entry point tree JSON #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/controllers/tree_controller.rb
Outdated
| json = JSON.parse(tree.instance_variable_get(:@bs_tree)) | ||
| end | ||
|
|
||
| render :json => json |
There was a problem hiding this comment.
you can set the response headers (content-type etc) and send the json as :text instead of reparsing
skateman
force-pushed
the
automate-tree-api-ui
branch
from
820c816
to
f132a31
Compare
|
I was re-reading the REST specification and now it sounds me more REST-y to use just GET with or without the |
skateman
force-pushed
the
automate-tree-api-ui
branch
from
f132a31
to
5d6e24d
Compare
skateman
changed the title
skateman
changed the title
miq-bot
changed the title
|
There are still some issues with the |
skateman
force-pushed
the
automate-tree-api-ui
branch
from
5d6e24d
to
3f60784
Compare
|
Ready to merge! |
|
Rubocop is right! |
skateman
force-pushed
the
automate-tree-api-ui
branch
from
3f60784
to
34ced25
Compare
|
Checked commit skateman@34ced25 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 🔥 Dialog editor calls for aid! And TreeBuilderAutomateEntrypoint will answer! 🎺 🎺
The dialog editor component needs a way to fetch the automate tree in JSON form. The data format is given and it won't change, but the way how I implemented this is not final and this piece of code should not be used as an example in any case.
If you send a GET request to
/tree/automate_entrypoint, it sends back the collapsed root node(s) withisLazyset totrue. If you send a POST request with a lazy node's key as anidattribute, it will return the node expanded with its children. The routes aren't final, I'd like to ask @martinpovolny's help for GET vs POST vs CSRF security.EDIT: Using GET for both lazy and root node requests, so no CSRF issues
We can't move this to the API as we're using TreeBuilders that are living in the UI repo. However, in the future I'd like to see these things fully API-driven.