Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to see saved chargeback report after linked MiqTask deleted #1965

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Allow to see saved chargeback report after linked MiqTask deleted #1965

merged 1 commit into from
Aug 24, 2017

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Aug 21, 2017 •
edited
Loading

Resolving Issue: Existing chargeback report would not be shown if linked MiqTask deleted
https://bugzilla.redhat.com/show_bug.cgi?id=1513013

This PR is follow-up to #1488

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1450272

@miq-bot add-label bug, reporting

\cc @lpichler

@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2017

Checked commit yrudman@48e3659 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2017

@yrudman Cannot apply the following label because they are not recognized: reporting

@miq-bot miq-bot added the bug label Aug 21, 2017
@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2017

@yrudman Cannot apply the following label because they are not recognized: reporting

@yrudman
Copy link
Contributor Author

yrudman commented Aug 21, 2017

@miq-bot add-label cloud intel/reporting

@yrudman yrudman closed this Aug 21, 2017
@yrudman yrudman reopened this Aug 21, 2017
@yrudman
Copy link
Contributor Author

yrudman commented Aug 23, 2017

@miq_bot add-label fine/yes

@mzazrivec could you review

@mzazrivec mzazrivec self-assigned this Aug 24, 2017
@mzazrivec mzazrivec added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 24, 2017
@mzazrivec mzazrivec merged commit e7a4fd8 into ManageIQ:master Aug 24, 2017
@yrudman yrudman deleted the show-chargeback-report-when-taks-deleted branch August 24, 2017 14:25
@simaishi
Copy link
Contributor

@yrudman The BZ referenced in this PR is closed as build with the orginal PR (#1488) is already released. Please create a new BZ describing the remaining issue this PR is fixing.

@yrudman
Copy link
Contributor Author

yrudman commented Nov 14, 2017

@simaishi
https://bugzilla.redhat.com/show_bug.cgi?id=1513013

simaishi pushed a commit that referenced this pull request Nov 20, 2017
@mzazrivec @simaishi
Merge pull request #1965 from yrudman/show-chargeback-report-when-tak…
b0a2fe6 
…s-deleted

Allow to see saved chargeback report after linked MiqTask deleted
(cherry picked from commit e7a4fd8)

https://bugzilla.redhat.com/show_bug.cgi?id=1514184
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit b0a2fe68215b962d5c23b610cb6897f043955cf4
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Aug 24 16:10:12 2017 +0200

    Merge pull request #1965 from yrudman/show-chargeback-report-when-taks-deleted
    
    Allow to see saved chargeback report after linked MiqTask deleted
    (cherry picked from commit e7a4fd80aad09cd2812c81cf7fdd129fd26f8234)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1514184

@yrudman yrudman mentioned this pull request May 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug fine/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yrudman @miq-bot @simaishi @mzazrivec