Fix custom Provisioning dialogs confirmation flash messages #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregP
force-pushed
the
provisioning_dialogs_flash_msg
branch
from
bb6f864
to
a20a4b9
Compare
|
Checked commit GregP@a20a4b9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@h-kataria Ready for review. |
h-kataria
approved these changes
Sep 19, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
Fix custom Provisioning dialogs confirmation flash messages (cherry picked from commit 4b45673) https://bugzilla.redhat.com/show_bug.cgi?id=1512694
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor messages for consistency and clarity. Display Custom Provisioning dialog description in both, accordion tree node and flash message, when doing Add/Edit/Cancel(Edit)/Delete.
Custom dialog names have a chance to be too brief/short when referring to them in display, thus dialog description is preferred.
https://bugzilla.redhat.com/show_bug.cgi?id=1481637
Screen shot prior to code refactoring/fix:
=====================================
Scree shots post code refactoring/fix: