Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In summary endpoints, use endpoint's name instead of role #2080

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 3, 2017

Description

In providers summary page, rename endpoints by what they do and not my their internal role name in the data base.

For example:

before after
Prometheus Host Name Metrics Host Name [ with type "Prometheus" ]
Prometheus_alerts Host Name Alerts Host Name [ with type "Prometheus" ]
Hawkular Host Name Metrics Host Name [ with type "Hawkular" ]

Screenshots

After:
screenshot-5b7fd941-f833-4da3-bedb-5e20f2fd793d-2017-09-03-15-01-45

Before:
screenshot-5b7fd941-f833-4da3-bedb-5e20f2fd793d-2017-09-03-15-01-35

@yaacov
Copy link
Member Author

yaacov commented Sep 3, 2017

@miq-bot add_label compute/containers

@simon3z @zeari @moolitayer @zakiva @himdel @mzazrivec please review

@miq-bot
Copy link
Member

miq-bot commented Sep 3, 2017

Checked commit yaacov@8218aea with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Sep 5, 2017
@mzazrivec mzazrivec added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 5, 2017
@mzazrivec mzazrivec merged commit 16ea78c into ManageIQ:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants