Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update monitor screen styling #2113

Merged
merged 1 commit into from
Sep 6, 2017
Merged

update monitor screen styling #2113

merged 1 commit into from
Sep 6, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Sep 5, 2017

This PR adds a "row" class div to fix an issue where both the expansion arrow and ellipses are off the screen.

Issue: #834

Old

screen shot 2017-09-05 at 3 09 55 pm

screen shot 2017-09-05 at 3 10 03 pm

New

screen shot 2017-09-05 at 3 07 58 pm

screen shot 2017-09-05 at 3 08 08 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label providers/containers, bug, styling/formatting

@epwinchell
Copy link
Contributor Author

@miq-bot assign @moolitayer

@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2017

@epwinchell Cannot apply the following labels because they are not recognized: providers/containers, styling/formatting

@epwinchell
Copy link
Contributor Author

@miq-bot add_label formatting/styling

@epwinchell
Copy link
Contributor Author

@miq-bot add_label monitor, fine/no

@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/b4c8dd5fa801e3ce57ae340df6293c633e5d4131 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Sep 6, 2017
@mzazrivec mzazrivec added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 6, 2017
@mzazrivec mzazrivec merged commit 817cbc1 into ManageIQ:master Sep 6, 2017
@moolitayer
Copy link

Thanks @epwinchell looks great 👍
Small followup in #2117

@epwinchell epwinchell deleted the monitor_styling branch October 25, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants