Support template sealing when publishing a VM #2182
Conversation
|
@masayag This looks fine, but the field name is not descriptive enough. The fields in the dialog get flattened into a hash and it can be hard to understand the intent of the data with a generic name. Sadly I just merged the dialog PR ManageIQ/manageiq#15981 not realizing the name since the entire file was new. I think it would be better if we called this field |
|
@gmcculloug seal_template is descriptive enough. I'll send new version for this one and a new patch to the yml dialog file, unless you'd rather to revert that PR |
|
@masayag No need to revert, let's just update the dialog. Thanks. |
RHV supports sealing a template when publishing a VM. https://bugzilla.redhat.com/show_bug.cgi?id=1373076
masayag
force-pushed
the
support_publish_vm
branch
from
c4cba2e
to
41e742a
Compare
|
Checked commit masayag@41e742a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/shared/views/_prov_dialog.html.haml
|
|
@gmcculloug this should be correlated with ManageIQ/manageiq#16045 |
|
@mzazrivec, the core's and provider's PRs were merged, can this be merged as well ? |
RHV supports sealing a template when publishing a VM.
https://bugzilla.redhat.com/show_bug.cgi?id=1373076
Screenshots are available here