Add severity to Alerts #2280
Merged
Add severity to Alerts #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
add_alert_severity
branch
9 times, most recently
from
001d8a3
to
5d07211
Compare
|
@miq-bot add_label pending core |
ZitaNemeckova
force-pushed
the
add_alert_severity
branch
from
5d07211
to
783f290
Compare
|
@miq-bot remove_label wip |
ZitaNemeckova
force-pushed
the
add_alert_severity
branch
from
783f290
to
5e84e48
Compare
|
@miq-bot remove_label wip |
|
All core dependencies are merged :) |
|
@h-kataria please review. Thanks :) |
| @@ -1168,7 +1168,8 @@ def view_to_hash(view) | |||
| when "result" | |||
| new_row[:cells] << {:span => result_span_class(row[col]), :text => row[col].titleize} | |||
| when "severity" | |||
| new_row[:cells] << {:span => severity_span_class(row[col]), :text => row[col].titleize} | |||
| value = row[col].nil? ? ' ' : row[col] | |||
| @@ -1220,6 +1221,14 @@ def severity_span_class(value) | |||
| end | |||
| end | |||
|
|
|||
| def severity_title(value) | |||
| if self.class == MiqPolicyController | |||
There was a problem hiding this comment.
instance_of? or === probably
| @@ -1,6 +1,7 @@ | |||
| describe "miq_policy/_alert_details.html.haml" do | |||
| before do | |||
| @alert = FactoryGirl.create(:miq_alert) | |||
| SEVERITIES = {"info" => _('Info'), "warning" => _('Warning'), "error" => _('Error')}.freeze | |||
There was a problem hiding this comment.
why is this constant here?
There was a problem hiding this comment.
Without it I'm getting this error:
ActionView::Template::Error:
uninitialized constant ActionView::TestCase::TestController::SEVERITIES
bc8a6d7
to
28ffe77
Compare
ZitaNemeckova
force-pushed
the
add_alert_severity
branch
from
28ffe77
to
5a01dea
Compare
|
Checked commits ZitaNemeckova/manageiq-ui-classic@d276118~...5a01dea with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control -> Explorer -> Alerts
https://www.pivotaltracker.com/story/show/151340254
Depends on ManageIQ/manageiq#16040 (Merged)
TODO:
After:
Fix for select picker is out of scope of this PR.
@miq-bot add_label wip, pending core