Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed VM visibility fieldset alignment. #2283

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

h-kataria
Copy link
Contributor

VM Visibility switch was inside an incorrect if block, moved it out of the if block

https://bugzilla.redhat.com/show_bug.cgi?id=1465465

@dclarizio please review/merge

before:
before

after:
after

VM Visibility switch was inside an incorrect if block, moved it out of the if block

https://bugzilla.redhat.com/show_bug.cgi?id=1465465
@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2017

Checked commit h-kataria@04e3845 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@dclarizio dclarizio merged commit 946b937 into ManageIQ:master Oct 4, 2017
@dclarizio dclarizio added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 4, 2017
@h-kataria h-kataria deleted the vm_visibility_fix branch October 5, 2017 18:24
simaishi pushed a commit that referenced this pull request Nov 14, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit ed38e85a46ca99beb34c848bd1ad0644d4fc4b62
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Oct 4 10:45:31 2017 -0700

    Merge pull request #2283 from h-kataria/vm_visibility_fix
    
    Fixed VM visibility fieldset alignment.
    (cherry picked from commit 946b9378cf8499048a93c62acb952bf4c5560972)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1498891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants